Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "u" modifier for Regex validators #17009

Merged
merged 5 commits into from
Jan 3, 2019
Merged

Add support for "u" modifier for Regex validators #17009

merged 5 commits into from
Jan 3, 2019

Conversation

Dzhuneyt
Copy link
Contributor

@Dzhuneyt Dzhuneyt commented Jan 3, 2019

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #16974

@samdark samdark added the pr:request for unit tests Unit tests are needed. label Jan 3, 2019
@yii-bot
Copy link

yii-bot commented Jan 3, 2019

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@Dzhuneyt
Copy link
Contributor Author

Dzhuneyt commented Jan 3, 2019

@samdark pushed unit test to cover the change.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need a line for changelog.

@Dzhuneyt
Copy link
Contributor Author

Dzhuneyt commented Jan 3, 2019

@samdark changelog entry added.

@samdark samdark merged commit a790685 into yiisoft:master Jan 3, 2019
@samdark
Copy link
Member

samdark commented Jan 3, 2019

Merged. Thank you!

@samdark samdark added this to the 2.0.16 milestone Jan 3, 2019
@Dzhuneyt Dzhuneyt deleted the 16974-regex-support-u-modifier branch January 4, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants